Mdeshotel refactor geometa and input forcing + tests#137
Merged
mdeshotel merged 127 commits intodevelopmentfrom Apr 16, 2026
Merged
Mdeshotel refactor geometa and input forcing + tests#137mdeshotel merged 127 commits intodevelopmentfrom
mdeshotel merged 127 commits intodevelopmentfrom
Conversation
Geo test pre refactor
Mdeshotel 9712 forcing input mod2
mxkpp
requested changes
Apr 10, 2026
mxkpp
left a comment
There was a problem hiding this comment.
Minor changes requested from the merge conflict resolution
|
I think will be ready to merge after it is tested on a cluster |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes refactoring + tests for InputForcings and GeoMeta classes. Incremental PRs were submitted to a pre-dev branch (Mdeshotel refactor geometa and input forcing + tests) for testing prior to this PR which merges the pre-dev branch into development. The table below maps out these incremental PRs/branches.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support