Skip to content

Mdeshotel refactor geometa and input forcing + tests#137

Merged
mdeshotel merged 127 commits intodevelopmentfrom
mdeshotel_pre_dev
Apr 16, 2026
Merged

Mdeshotel refactor geometa and input forcing + tests#137
mdeshotel merged 127 commits intodevelopmentfrom
mdeshotel_pre_dev

Conversation

@mdeshotel
Copy link
Copy Markdown

@mdeshotel mdeshotel commented Apr 10, 2026

This PR includes refactoring + tests for InputForcings and GeoMeta classes. Incremental PRs were submitted to a pre-dev branch (Mdeshotel refactor geometa and input forcing + tests) for testing prior to this PR which merges the pre-dev branch into development. The table below maps out these incremental PRs/branches.

Branch Branched from PR
1 geo_test_pre_refactor Development (~3/24/2026) 1. #125
2 mdeshotel_NGWPC-9713_WrfGeoHydroMeta Development (~2/25/2026) 2. #101
3 mdeshotel_NGWPC-9713_GeoMeta_linting mdeshotel_NGWPC-9713_WrfGeoHydroMeta 3. #105
4 mdeshotel-9713_modularize mdeshotel_NGWPC-9713_GeoMeta_linting 4. #126
5 mdeshotel-9712_forcingInputMod1 mdeshotel-9713_modularize 5. #127
6 mdeshotel-9712_forcingInputMod2 mdeshotel-9712_forcingInputMod1 6. #128

Additions

Removals

Changes

Testing

  1. The unit tests in the repo are passing.
  2. Testing was performed using run_suite.sh in RTE.
  3. Testing was performed on a cluster.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux

@mdeshotel mdeshotel marked this pull request as draft April 10, 2026 16:32
@mxkpp mxkpp marked this pull request as ready for review April 10, 2026 19:44
@mxkpp mxkpp self-requested a review April 10, 2026 19:44
Copy link
Copy Markdown

@mxkpp mxkpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested from the merge conflict resolution

Comment thread NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/historical_forcing.py Outdated
Comment thread NextGen_Forcings_Engine_BMI/NextGen_Forcings_Engine/historical_forcing.py Outdated
@mxkpp
Copy link
Copy Markdown

mxkpp commented Apr 10, 2026

I think will be ready to merge after it is tested on a cluster

@mdeshotel mdeshotel requested a review from mxkpp April 16, 2026 15:15
Copy link
Copy Markdown

@mxkpp mxkpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after cluster runs

@mdeshotel mdeshotel changed the title Mdeshotel pre dev Mdeshotel refactor geometa and input forcing + tests Apr 16, 2026
@mdeshotel mdeshotel merged commit fcb092c into development Apr 16, 2026
6 checks passed
@peterkronenberg-rtx peterkronenberg-rtx deleted the mdeshotel_pre_dev branch April 17, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants