Fix durations in forcing config files for medium-range lagged ensemble#138
Merged
mxkpp merged 3 commits intodevelopmentfrom Apr 14, 2026
Merged
Fix durations in forcing config files for medium-range lagged ensemble#138mxkpp merged 3 commits intodevelopmentfrom
mxkpp merged 3 commits intodevelopmentfrom
Conversation
This was referenced Apr 13, 2026
jswade-rtx
approved these changes
Apr 13, 2026
jswade-rtx
left a comment
There was a problem hiding this comment.
Changes look good to adjust the lagged ensemble forcing engine templates.
Author
|
I pushed one more minor improvement to the handling of error messages in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the medium-range lagged ensemble workflow, this adjusts the realization durations (parameter
ForecastInputHorizons) that are written in the forcing configuration files, to match the intended time-windowing.This also improves error messaging (see below for details).
This should be reviewed in conjunction with related PRs on other repositories:
NGWPC/nwm-rte#52
NGWPC/nwm-msw-mgr#54
NGWPC/nwm-fcst-mgr#18
Changes
err_out_screento include traceback in to the LOG, in addition to sending the traceback tostderras had been done before.Testing
docker_run python "/ngen-app/bin/bin_mounted/run_forecast.py" -n 2 -dt "2025-09-15 00:00:00" -rname "${fcst_run_name}_mr_le" -fconfig medium_range -le "" ""Screenshots
Notes
RefcstBDateProcis overridden on-the-fly bynwm-fcst-mgr, butForecastInputHorizonsis taken as-is from each forcing config file.Todos