Skip to content

Conversation

@anjalitrace2-nhs
Copy link
Contributor

@anjalitrace2-nhs anjalitrace2-nhs commented Jan 22, 2026

Marked as draft because I'm using this branch to alter seed runs on the bastion and would be nicer to wait until the branch this merges into (feature/SAFO6-NRL-1841-performance-tests-public-mode) is in develop for less mess! Tidied up & ready for review now

  • Make perf tests give a more detailed output report including a breakdown per scenario
  • The csv generated by the seed script now does not include any unprocessed items that failed to be upserted to dynamo
    • Still not an accurate representation of pointer count increase - items which were updated rather than created will count as processed and therefore be included in this csv too
  • When regenerating the input csv, cap it by default at 1.5m rows. As long as there are more rows than test iterations, this is sufficient as input for the perf tests. Generally we have 9k-14k iterations. Trying to load a 15m row csv into the test VUs was very slow and ate up >350% of my machine's CPU before the tests had even begun!
  • Point perftest env at 15m table for 15m testing
    • Updated the readme's instructions on how to do this
  • Ramped the TPS down to 1 per scenario. Scenarios run in parallel so this gives roughly producer = 5 TPS, consumer = 7 TPS.
  • Redid the baseline testing with these new TPS so that we could accurately compare to higher volumes

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 907c67c6c8cf262e5bf4a64a3e592d00f2ab0b85
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 907c67c6c8cf262e5bf4a64a3e592d00f2ab0b85
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

…not load a 15m row csv into the test runner VUs - they are unhappy
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: fcb24fdf99ced108bf6200e0b90583e37d364bc2
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

@anjalitrace2-nhs anjalitrace2-nhs marked this pull request as ready for review January 26, 2026 10:18
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: ec2270128b9b88d49d54f11776f47a1753fad183
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: efcbdf522afdbcbfcea22f18a10c3abf7b6afb30
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: f0fbb4400a8573857c2ed48c9fca1d9130ad90e5
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

…und up to the next multiple e.g. 1.5m -> 2m
@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 09bfba3de492c15441a5c1e2f41a7e422a703cf3
URL: https://nrl1875-01ba47.api.record-locator.dev.national.nhs.uk/

Copy link
Contributor

@sandyforresternhs sandyforresternhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@anjalitrace2-nhs anjalitrace2-nhs merged commit c8e0b75 into develop Jan 27, 2026
9 checks passed
@anjalitrace2-nhs anjalitrace2-nhs deleted the NRL-1875-seed-script-make-better-output branch January 27, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants