NRL-786 new parent class that does not allow extra fields for pydantic models #781

eesa456 · 2024-12-19T15:29:36Z

No description provided.

…c models

github-actions · 2024-12-19T15:31:44Z

💥 Something went wrong while building the pull request environment.
Check Output Logs

github-actions · 2024-12-19T15:37:36Z

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

github-actions · 2024-12-19T15:51:41Z

🚀 PR environment successfully deployed.
Commit Hash: 2f6eac9a53dee48e897c4f870629ec3126c2860b
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-19T16:09:22Z

🚀 PR environment successfully deployed.
Commit Hash: 7be77386b2c5019593044165bb31b6bc3d6ee616
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

github-actions · 2024-12-19T16:18:37Z

🚀 PR environment successfully deployed.
Commit Hash: d50ae24dfeadfbea6351e3331fb7dc0c4d35697d
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2024-12-20T09:39:44Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2024-12-20T09:45:00Z

🚀 PR environment successfully deployed.
Commit Hash: 93025f14b0bfc0ae203f5a754c37e1ebfbeb4ec7
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

github-actions · 2025-02-07T15:04:10Z

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

github-actions · 2025-02-07T15:15:31Z

🚀 PR environment successfully deployed.
Commit Hash: ec405a5fbff8d8def0aae399b4336a3c2ed6b404
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs · 2025-02-11T10:42:04Z

layer/nrlf/core/parent_model.py

+
+
+class ParentExtension(BaseModel):
+    valueCodeableConcept: Annotated[


If we want to allow producers to define their own extensions, do we need value to be more generic to support extensions with values of types other than CodableConcepts?

I'm not sure I've just kept the extension as its always been defined but could make it more generic ?

As discussed offline, we're going to support extensions that have a CodableConcept value only on the initial implementation. We will add a question to producer supplier onboarding to confirm if the pointers being created will have other custom extentions and then we'll extend our validation as required.

sonarqubecloud · 2025-02-12T10:46:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-02-12T10:51:41Z

🚀 PR environment successfully deployed.
Commit Hash: f26da9f97e0b24953a2b78b3fabc5605f56d3bf5
URL: https://nrl786-4ab1a4.api.record-locator.dev.national.nhs.uk/

NRL-786 new parent class that does not allow extra fields for pydanti…

7affc4c

…c models

NRL-786 fix test

2f6eac9

eesa456 had a problem deploying to pull-request December 19, 2024 15:36 — with GitHub Actions Failure

eesa456 temporarily deployed to pull-request December 19, 2024 15:48 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 19, 2024 15:51 — with GitHub Actions Failure

NRL-786 update import to remove layer

7be7738

eesa456 temporarily deployed to pull-request December 19, 2024 16:07 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request December 19, 2024 16:09 — with GitHub Actions Failure

NRL-786 fix error message

d50ae24

eesa456 temporarily deployed to pull-request December 19, 2024 16:15 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 19, 2024 16:18 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 19, 2024 16:20 — with GitHub Actions Inactive

NRL-786 fix warning in test

93025f1

eesa456 temporarily deployed to pull-request December 20, 2024 09:41 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 20, 2024 09:45 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request December 20, 2024 09:47 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev December 24, 2024 14:21 — with GitHub Actions Inactive

hamzakhan24-nhs had a problem deploying to dev December 24, 2024 14:23 — with GitHub Actions Failure

hamzakhan24-nhs temporarily deployed to dev December 24, 2024 14:30 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev December 24, 2024 14:32 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev December 24, 2024 14:35 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request February 7, 2025 14:58 — with GitHub Actions Inactive

eesa456 had a problem deploying to pull-request February 7, 2025 15:00 — with GitHub Actions Failure

eesa456 temporarily deployed to pull-request February 7, 2025 15:10 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request February 7, 2025 15:13 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request February 7, 2025 15:15 — with GitHub Actions Inactive

eesa456 temporarily deployed to pull-request February 7, 2025 15:17 — with GitHub Actions Inactive

mattdean3-nhs reviewed Feb 11, 2025

View reviewed changes

hamzakhan24-nhs temporarily deployed to dev February 11, 2025 16:49 — with GitHub Actions Inactive

hamzakhan24-nhs had a problem deploying to dev February 11, 2025 16:51 — with GitHub Actions Failure

hamzakhan24-nhs temporarily deployed to dev February 11, 2025 16:55 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev February 11, 2025 16:58 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev February 11, 2025 17:02 — with GitHub Actions Inactive

hamzakhan24-nhs temporarily deployed to dev February 11, 2025 17:03 — with GitHub Actions Inactive

Merge branch 'develop' into feature/eema1-NRL-786-rejectExtraFields

f26da9f

mattdean3-nhs temporarily deployed to pull-request February 12, 2025 10:46 — with GitHub Actions Inactive

mattdean3-nhs approved these changes Feb 12, 2025

View reviewed changes

mattdean3-nhs temporarily deployed to pull-request February 12, 2025 10:48 — with GitHub Actions Inactive

mattdean3-nhs temporarily deployed to pull-request February 12, 2025 10:51 — with GitHub Actions Inactive

mattdean3-nhs temporarily deployed to pull-request February 12, 2025 10:53 — with GitHub Actions Inactive

eesa456 merged commit 57c177f into develop Feb 12, 2025
8 checks passed

eesa456 deleted the feature/eema1-NRL-786-rejectExtraFields branch February 12, 2025 12:07

eesa456 temporarily deployed to pull-request February 12, 2025 12:07 — with GitHub Actions Inactive



		class ParentExtension(BaseModel):
		valueCodeableConcept: Annotated[

NRL-786 new parent class that does not allow extra fields for pydantic models #781

NRL-786 new parent class that does not allow extra fields for pydantic models #781

Uh oh!

Conversation

eesa456 commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

github-actions bot commented Dec 19, 2024

Uh oh!

sonarqubecloud bot commented Dec 20, 2024

Quality Gate passed

Uh oh!

github-actions bot commented Dec 20, 2024

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

github-actions bot commented Feb 7, 2025

Uh oh!

mattdean3-nhs Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

eesa456 Feb 11, 2025

Choose a reason for hiding this comment

Uh oh!

mattdean3-nhs Feb 12, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 12, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants