Skip to content

Conversation

@axelkrastek1-nhs
Copy link
Contributor

No description provided.

@github-actions
Copy link

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link

💥 Something went wrong while building the pull request environment.
Check Output Logs

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 41000c3b5a6f02bb62d70d9992930bd846c9e443
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs
Copy link
Contributor

As discussed offline - I had a little play with using the object_pairs_hook parameter for JSON.loads for this. The idea being that we find the dupes as the JSON is loaded instead of loading it and then parsing it afterwards.

The code changes I made are on this branch: https://github.com/NHSDigital/NRLF/tree/feature/made14-NIR-1215-use-hooks-instead

I didn't have time to get all the unit tests passing before going on leave but I think the progress I made suggests (to me at least) that it's feasible to use object_pairs_hook to do what we want.

One to discuss - whether we put more time into trying to get a simpler solution or we've spent enough time and this solution is the way we want to go.

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 8e9c9a8d1b19e70bf4946ee54934cea0229f0847
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: f95069891085d9c2ea4a3b24661287a49bd2807a
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 023e514afc8a6f7a66e84ecf545001531f3ada82
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 9601c3fb39e947bce49d165af826502387fe3175
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 67af0765de03b9aabdf23293a9d6da6f0eecb94f
URL: https://nrl1215-ac820b.api.record-locator.dev.national.nhs.uk/

@mattdean3-nhs mattdean3-nhs merged commit 4c43235 into develop Jan 30, 2025
8 checks passed
@mattdean3-nhs mattdean3-nhs deleted the feature/axkr1-NRL-1215-duplicate-fields branch January 30, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants