NRL-1205 dont ignore category if type is given for search

[eesa456]

No description provided.

[github-actions]

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 4ac28a35d97172c28c63a164bf37db34cf908b5d
URL: https://nrl1205-3a0f35.api.record-locator.dev.national.nhs.uk/

[katebobyn-nhs]

If I'm reading this right, the test is

1. Creating a pointer of type: MHCP, cat: Care Plan
2. Creating a pointer of type: NEWS2, cat: Obs
3. Searching for pointers of type: MHCP, cat: Care Plan
   It then expects the one result (pointer 1) since pointer 2 would be filtered out by both criteria.

I think to prove both filters are being applied there needs to be a test scenario where, e.g., you search for type: MHCP, cat: Obs
Then the expected result is an empty searchset bundle because 1 is filtered out on the basis of failure to match category, and 2 is filtered out on the basis of failure to match type.

[eesa456]

Yeah I'll add that I'll also add searching with multiple categories and the one type to show that the optimisation for the single type is still used and that it wont get other categories even if they're provided because it isnt for that type

[katebobyn-nhs]

Can we add feature tests?

[eesa456]

Can we add feature tests?

There are already some feature tests I wrote back when I did the category filter work but I can do an additional scenario that is basically the unit test you mentioned above but an integration test

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: cb69b2c7d1759df23229bc4c3e033e52bbf56177
URL: https://nrl1205-3a0f35.api.record-locator.dev.national.nhs.uk/

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: aba621417a7b24fc799ce9f8d97a9149525509cd
URL: https://nrl1205-3a0f35.api.record-locator.dev.national.nhs.uk/

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 PR environment successfully deployed.
Commit Hash: 717b2c327b32d8d3b0342c8858a8dcc1008d8422
URL: https://nrl1205-3a0f35.api.record-locator.dev.national.nhs.uk/

[mattdean3-nhs]

LGTM 👍

[github-actions]

💥 Something went wrong while destroying the pull request environment.
Check Output Logs