Skip to content

NRL-1473 Fix PR env destroy workflow #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdean3-nhs merged 3 commits into from
Jul 8, 2025
Merged

NRL-1473 Fix PR env destroy workflow #956

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10ddff7
[NRL-1473] Build artifacts before TF destroy of PR envs
mattdean3-nhs Jun 20, 2025
395d75a
Merge branch 'develop' into feature/made14-NRL-1473-fix-pr-destroy
mattdean3-nhs Jun 30, 2025
605b630
[NRL-1473] Add get-s3-perms to destroy workflow
mattdean3-nhs Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/pr-env-destroy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ run-name: "Destroy PR Environment - #${{ github.event.pull_request.number }} (${
on:
pull_request:
types: [closed]
workflow_dispatch:

concurrency:
group: environment-${{ github.event.pull_request.number }}
Expand Down Expand Up @@ -73,9 +74,11 @@ jobs:
- name: Terraform Init
run: |
terraform -chdir=terraform/infrastructure init
terraform -chdir=terraform/infrastructure workspace new ${{ needs.set-environment-id.outputs.environment_id }} || \
terraform -chdir=terraform/infrastructure workspace select ${{ needs.set-environment-id.outputs.environment_id }}

- name: Build artifacts
run: make build get-s3-perms

- name: Terraform Destroy
run: |
terraform -chdir=terraform/infrastructure destroy \
Expand Down