Skip to content

NRL-853 set up DynamoDB tiered backup plan #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdean3-nhs merged 4 commits into from
Aug 19, 2025
Merged

NRL-853 set up DynamoDB tiered backup plan #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
001cf2f
NRL-853 set up DynamoDB backup plan for weekly and monthly with trans…
katebobyn-nhs Jul 8, 2025
4c9cde6
[NRL-853] WIP - Switch copy_action to list, still more to do on that
mattdean3-nhs Jul 22, 2025
84b3f7d
[NRL-853] Fix backup config params. Fix cron definitions
mattdean3-nhs Aug 18, 2025
f99aeff
[NRL-853] Remove incorrect optional. Remove unused cold_storage_after
mattdean3-nhs Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 35 additions & 10 deletions terraform/account-wide-infrastructure/dev/aws-backup.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ module "source" {
"compliance_resource_types" : [
"S3"
],
"enable" = true,
"enable" : true,
"rules" : [
{
"copy_action" : {
"delete_after" : 4
},
"copy_action" : [{
"delete_after" : 4,
}],
"lifecycle" : {
"delete_after" : 2
},
Expand All @@ -132,14 +132,39 @@ module "source" {
"enable" : true,
"rules" : [
{
"copy_action" : {
"delete_after" : 4
},
"name" : "daily",
"schedule" : "cron(0 0 * * ? *)",
"copy_action" : [{
"delete_after" : 4,
}],

"lifecycle" : {
"delete_after" : 2
},
"name" : "daily_kept_for_2_days",
"schedule" : "cron(0 0 * * ? *)"
}
},
{
"name" : "monthly"
"schedule" : "cron(30 0 ? * 4#1)" # first Thursday each month from 00:30
"copy_action" : [{
"cold_storage_after" : 3,
"delete_after" : 100 # ensures there will always be min 3
}],
"lifecycle" : {
"delete_after" : 2
}

},
{
"name" : "weekly" # overlaps with monthly
"schedule" : "cron(30 0 ? * 4)" # every Thursday from 00:30 to precede releases
"copy_action" : [{
"cold_storage_after" : 14 # ensures 2 warm including one from previous release
"delete_after" : 105
}],
"lifecycle" : {
"delete_after" : 2
}

}
],
"selection_tag" : "NHSE-Enable-DDB-Backup"
Expand Down
19 changes: 10 additions & 9 deletions terraform/account-wide-infrastructure/modules/backup-source/backup_plan.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ resource "aws_backup_plan" "default" {
rule_name = rule.value.name
target_vault_name = aws_backup_vault.main.name
schedule = rule.value.schedule
enable_continuous_backup = rule.value.enable_continuous_backup != null ? rule.value.enable_continuous_backup : null
enable_continuous_backup = rule.value.enable_continuous_backup
lifecycle {
delete_after = rule.value.lifecycle.delete_after != null ? rule.value.lifecycle.delete_after : null
cold_storage_after = rule.value.lifecycle.cold_storage_after != null ? rule.value.lifecycle.cold_storage_after : null
delete_after = rule.value.lifecycle.delete_after
cold_storage_after = rule.value.lifecycle.cold_storage_after
}
dynamic "copy_action" {
for_each = rule.value.copy_action != null ? rule.value.copy_action : {}
for_each = rule.value.copy_action
content {
lifecycle {
delete_after = copy_action.value
delete_after = copy_action.value.delete_after
}
destination_vault_arn = var.backup_copy_vault_arn
}
Expand All @@ -44,14 +44,15 @@ resource "aws_backup_plan" "dynamodb" {
target_vault_name = aws_backup_vault.main.name
schedule = rule.value.schedule
lifecycle {
delete_after = rule.value.lifecycle.delete_after != null ? rule.value.lifecycle.delete_after : null
cold_storage_after = rule.value.lifecycle.cold_storage_after != null ? rule.value.lifecycle.cold_storage_after : null
delete_after = rule.value.lifecycle.delete_after
cold_storage_after = rule.value.lifecycle.cold_storage_after
}
dynamic "copy_action" {
for_each = rule.value.copy_action != null ? rule.value.copy_action : {}
for_each = rule.value.copy_action
content {
lifecycle {
delete_after = copy_action.value
delete_after = copy_action.value.delete_after
cold_storage_after = copy_action.value.cold_storage_after
}
destination_vault_arn = var.backup_copy_vault_arn
}
Expand Down
14 changes: 8 additions & 6 deletions terraform/account-wide-infrastructure/modules/backup-source/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ variable "backup_plan_config" {
delete_after = optional(number)
cold_storage_after = optional(number)
})
copy_action = optional(object({
delete_after = optional(number)
}))
copy_action = optional(list(object({
delete_after = optional(number)
cold_storage_after = optional(number)
})))
}))
})
}
Expand All @@ -106,9 +107,10 @@ variable "backup_plan_config_dynamodb" {
delete_after = number
cold_storage_after = optional(number)
})
copy_action = optional(object({
delete_after = optional(number)
}))
copy_action = optional(list(object({
delete_after = optional(number)
cold_storage_after = optional(number)
})))
})))
})

Expand Down