Skip to content

Conversation

@eesa456
Copy link
Contributor

@eesa456 eesa456 commented Jul 11, 2025

No description provided.

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 80b7518095f41e5780380f80baee4ca7cf2f8d2a
URL: https://nrl1048-33f34d.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs previously approved these changes Jul 15, 2025
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Happy to leave the java thing until a later date - up to you.

function _generate_consumer_from_fhir() {
rm ./swagger/consumer.yaml
touch ./swagger/consumer.yaml
java -jar ./tools/fhir-swagger-generator-4.11.1-cli.jar "DocumentReference(read,search)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this has gone, we can get rid of java from .tool-versions 🥳

Want to add that here? or maybe add it to the next dependency update ticket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll do it here 😎

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: b728a5e9632108cd511d6b6327f12ae7656c5d7c
URL: https://nrl1048-33f34d.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs previously approved these changes Jul 17, 2025
mattdean3-nhs
mattdean3-nhs previously approved these changes Jul 17, 2025
@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: d1ac2e974075b80b74cda18cc517c1260f2c655d
URL: https://nrl1048-33f34d.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: d1ac2e974075b80b74cda18cc517c1260f2c655d
URL: https://nrl1048-33f34d.api.record-locator.dev.national.nhs.uk/

@sonarqubecloud
Copy link

@github-actions
Copy link

🚀 PR environment successfully deployed.
Commit Hash: 36811a542f5a0f4c1e6f1e62501d8c86eabc46d8
URL: https://nrl1048-33f34d.api.record-locator.dev.national.nhs.uk/

@eesa456 eesa456 merged commit f5459c0 into develop Jul 17, 2025
9 checks passed
@eesa456 eesa456 deleted the feature/eema1-NRL-1048-removeApiDocumentationFromApiGateway branch July 17, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants