Add new variable into Sheffield regex#178
Merged
Conversation
… look for variant presence first
shilpigoeldev
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the CASREF refresh Nov 2025, QA identified an issue where a new variable is appearing in the Sheffield data meaning that records with this string in the Headline result are not being imported.
New string added into regex so that that records get imported and handled correctly and given test status of 1 or 2 as applicable. Also reordered the logic in the method so that it looks for variant details as priority one.
Count of unique SRIs imported by the Sheffield colorectal importer now match the raw counts exactly.