Sheffield BRCA new normal genotype str #179
Merged
shilpigoeldev merged 1 commit intodevelopfrom Mar 9, 2026
Merged
Conversation
shilpigoeldev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added new string to be marked as Normal genotype for Sheffield. This resolves https://nhsd-jira.digital.nhs.uk/browse/NDRS2-3684
Why?
After the CASREF refresh Nov 2025, QA identified an issue where a new variable is appearing in the Sheffield data meaning that records with this string were being marked as default to unknown rather normal.
How?
New string added into regex so that that records are marked correctly with test status of 1 or 2 as applicable. Also now handler has variants case precedence over normal cases.
Testing ?
Test added for new string case.
Anything else ?
No