Add new variables to Birmingham germline importer#180
Merged
Conversation
shilpigoeldev
requested changes
Mar 6, 2026
test/lib/import/colorectal/providers/birmingham/birmingham_handler_colorectal_test.rb
Outdated
Show resolved
Hide resolved
shilpigoeldev
requested changes
Mar 6, 2026
test/lib/import/colorectal/providers/birmingham/birmingham_handler_colorectal_test.rb
Outdated
Show resolved
Hide resolved
test/lib/import/colorectal/providers/birmingham/birmingham_handler_colorectal_test.rb
Outdated
Show resolved
Hide resolved
shilpigoeldev
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the CASREF Nov 2025 refresh, around 340 SRIs are not being imported for Birmingham colorectal.
Solution:
New indications and new genes to add to constants file (new indications into COLORECTAL_GENE_MAP)
Addition of one new indication into sometimes_tested? method as not all of the genes in that 'panel' are always tested.
https://nhsd-jira.digital.nhs.uk/browse/NDRS2-3690