Draft
Conversation
swebberuk
force-pushed
the
remove-exclusions-from-lint
branch
4 times, most recently
from
87e0b7e to
b30d6ae
Compare
swebberuk
force-pushed
the
remove-exclusions-from-lint
branch
from
0318b02 to
415a73a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove models from
ALLOWLISTED_MODELSinlint_model_usage_in_views.py.As mentioned in comment of #1016 - We shouldn't be adding to
ALLOWLISTED_MODELS, the linter is there to avoid us unintentionally exposing data from other providers.Instead of
Model.objects.getyou can access them via theAppointmentinstance, and this will ensure that access is scoped to the user's allowed providers (as the appointment is already provider scoped).Jira link
Review notes
Review checklist