[DTOSS-12358] - feat(ci): add smoke test token parameter and configuration#1085
Open
josielsouzanordcloud wants to merge 9 commits intomainfrom
Open
[DTOSS-12358] - feat(ci): add smoke test token parameter and configuration#1085josielsouzanordcloud wants to merge 9 commits intomainfrom
josielsouzanordcloud wants to merge 9 commits intomainfrom
Conversation
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Error
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Error
josielsouzanordcloud
force-pushed
the
DTOSS-12358-waf-smoke-test-issue
branch
from
321741e to
de5fbd1
Compare
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
Adds a `smokeTestToken` parameter to the Azure DevOps pipeline and GitHub Actions workflow, allowing for a dynamic token in the deployment process. Updates the Terraform configuration to include this token and adds a WAF rule in the container apps module to bypass firewall rules using this token. Also, modifies the smoke test script to use this token. Refs: DTOSS-12358
…ation Refs: DTOSS-12358
…): increase smoke test timeout for PR environments Increase the smoke test timeout to accommodate Front Door certificate provisioning in PR environments. Add masking of the SMOKE_TEST_TOKEN in the CI workflow. Refs: DTOSS-12358
…policy Adds a conditional configuration to enable or disable the smoke test bypass rule in the CDN front door firewall policy. Refs: DTOSS-12358
josielsouzanordcloud
force-pushed
the
DTOSS-12358-waf-smoke-test-issue
branch
from
fa5c2f5 to
d43cd3d
Compare
josielsouzanordcloud
temporarily deployed
to
review
GitHub Actions
Inactive
|
The review app is available at this URL: |
josielsouzanordcloud
temporarily deployed
to
review
GitHub Actions
Inactive
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
|
❌ The last analysis has failed. |
|
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
josielsouzanordcloud
had a problem deploying
to
review
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a smoke test token parameter and configuration to the deployment pipeline and Terraform setup. The changes include:
smokeTestTokenparameter to both Azure DevOps and GitHub CI pipelines..github/workflows/stage-4-deploy.yamlfile to generate a random smoke test token during the deployment process and pass it to the pipeline.infrastructure/modules/container-apps/front_door.tffile to include a custom WAF rule that allows requests with a specific User-Agent header (containing the smoke test token) to bypass the firewall.enable_smoke_test_bypassandsmoke_test_tokento both Terraform and module variable files, and propagating them through the infrastructure setup.scripts/bash/container_app_smoke_test.shscript to include the smoke test token in the User-Agent header of requests.These changes are necessary to enable a more secure smoke testing process while allowing specific test requests to bypass the firewall rules in development and review environments.
Type of change
Jira link
DTOSS-12358
Review notes
smokeTestTokenparameter is correctly passed through all deployment stages and environments.enable_smoke_test_bypassandsmoke_test_tokenvariables are correctly set in all environment variable files (variables.tfvars) and propagated to the Terraform modules.Breaking changes
None
Impact
Review checklist