Fix date/time bug

[cameronhargreaves1-nhs]

• change clinic.starts_at to clinic_slot.starts_at

Description

Jira link

DTOSS-12483

Review notes

Review checklist

• Check database queries are correctly scoped to current_provider

[swebberuk]

Change looks good. Works for me.

I think we should add a unit test for this. We already have tests for ClinicSlotPresenter in TestClinicSlotPresenter of test_appointment_presenters.py but looks like we never added a test for slot_timestamp_single_line.

Think following test will be sufficient. Without the change in this PR it fails as slot_timestamp_single_line wrongly returns 2 January 2025 (4 months ago) \n 9am (30 minutes). With change in this PR then the test passes.

    @time_machine.travel(datetime(2025, 5, 19, tzinfo=tz.utc))
    def test_slot_timestamp_single_line(self, clinic_slot_mock):
        clinic_slot_mock.starts_at = datetime(2025, 1, 2, 10, 30)
        clinic_slot_mock.duration_in_minutes = 30
        clinic_slot_mock.clinic.starts_at = datetime(2025, 1, 2, 9, 0)

        assert (
            ClinicSlotPresenter(clinic_slot_mock).slot_timestamp_single_line
            == 
            "2 January 2025 (4 months ago) \n 10:30am (30 minutes)"
        )

[swebberuk]

👍🏼

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud