Fix: [AEA-6327] - missing prescriptions fix

[jonathanwelch1-nhs]

Summary

https://nhsd-jira.digital.nhs.uk/browse/AEA-6327
https://nhsd-jira.digital.nhs.uk/browse/AEA-6276

• Routine Change

Details

Fixed the state that got corrupted when you searched for a prescription and clicked back.
Previously, clicking on View a Prescription altered the saved state which got loaded and rendered on the page. It is now not corrupted and displays the original full search
Also inserts issueNumber=0 which equals to falsy, and so isnt chained on to any endpoint calls when you click back so is more hardy

[github-actions]

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-6327

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Orkastrated]

I think all this can be further simplified into a fairly concise switch statement and generic function, something like:

useEffect(() => {
  const runSearch = async () => {
    setLoading(true)

    // Use searchType from SearchProvider to determine which parameter to search with
    const searchParams = new URLSearchParams()
    // Check original parameters first, then fall back to current search context
    const originalSearchParams = navigationContext.getOriginalSearchParameters()

	const handleSearchParams = (searchType) => {
		const searchParam = originalSearchParams[searchType] || searchContext[searchType]
		if (!searchParam){
			// invalid redirect?
			navigate(FRONTEND_PATHS.SEARCH_BY_PRESCRIPTION_ID)
		}
		searchParams.append(searchType, param)
	}

	switch(searchContext.searchType) {
		case "nhs":
			handleSearchParams("nhsNumber")
		case: "prescriptionId":
			handleSearchParams("prescriptionId")
		case: "basicDetails":
			handleSearchParams("nhsNumber")
		default:
			// invalid redirec?
			navigate(FRONTEND_PATHS.SEARCH_BY_PRESCRIPTION_ID)
	}

	try{
		...
	}
	// and the rest
}

[Orkastrated]

And if you do this i'd probably look to make the searchType nhsNumber rather than just nhs, that way you could probably tweak the switch statement to:

switch(searchContext.searchType) {
		case "nhs":
		case: "prescriptionId":
			handleSearchParams(searchType)
		case: "basicDetails":
			handleSearchParams("nhsNumber")
		default:
			// invalid redirec?
			navigate(FRONTEND_PATHS.SEARCH_BY_PRESCRIPTION_ID)
	}

[Orkastrated]

Also those searchTypes should probably be an enum