Conversation
Signed-off-by: Steph Housden <167300771+stephhou@users.noreply.github.com>
| return self.changed_required_error_message() | ||
|
|
||
| def page_title(self): | ||
| if self.presenter.increased_or_decreased(): #TODO: What's the best condition to use here? |
There was a problem hiding this comment.
What is the best condition to use here?
There was a problem hiding this comment.
I'd guess looking at label() you're best of doing self.tobacco_smoking_history.is_normal() and flipping the two versions around so normal is first?
| return self.changed_required_error_message() | ||
|
|
||
| def page_title(self): | ||
| if self.presenter.increased_or_decreased(): #TODO: What's the best condition to use here? |
There was a problem hiding this comment.
I'd guess looking at label() you're best of doing self.tobacco_smoking_history.is_normal() and flipping the two versions around so normal is first?
| {% from 'nhsuk/components/back-link/macro.jinja' import backLink %} | ||
| {% from 'nhsuk/components/fieldset/macro.jinja' import fieldset %} |
There was a problem hiding this comment.
Shouldn't need these here do you?
There was a problem hiding this comment.
good catch, I must have picked up too much in the copy and past
| </section> | ||
| </div> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
If this is needed then the indentation is wrong :( Don't "think" it is at a glance in here however, can only see two opening divs
There was a problem hiding this comment.
I ran format doc on it, I'll double check
|
2 participants
What is the change?
Overwriting the default page title on every page
Why are we making this change?
For accessibility and user orientation