Support date ranges in C-FIND query identifier#49
Merged
Conversation
| "ORDER BY scheduled_date, scheduled_time" | ||
| ), | ||
| ["20240101"], | ||
| ) |
Contributor
There was a problem hiding this comment.
is there a case for a few integration tests confirming that a given input returns a given output, or are we operating on the time-worn principle that "SELECT isn't broken"?
Contributor
Author
There was a problem hiding this comment.
Yes, good point, I had to amend the date range query, I've added integration test coverage here: e9b0fd1#diff-98e9cf22fda17f1dcd5b44914bc967c70ca8c9cc0c2f85721fc7a9bf2a408269R99-R158
carlosmartinez
approved these changes
Mar 17, 2026
steventux
force-pushed
the
feat/support-date-range-c-find-queries
branch
2 times, most recently
from
5ab54f4 to
e9b0fd1
Compare
Conformance to DICOM Scheduled Procedure Step Start Date means support for date ranges. If the query param is '*' matches on any date will be returned. If the query param starts with '-' matches on records until the date param will be returned. If the query param ends with '-' matches on records on and after the date param will be returned. If the query param contains '-' between two date params, records between and including the two dates will be returned.
steventux
force-pushed
the
feat/support-date-range-c-find-queries
branch
from
50518b8 to
9352a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Conformance to DICOM Scheduled Procedure Step Start Date means support for date ranges.
See
https://dicom.nema.org/medical/dicom/current/output/chtml/part04/sect_C.2.2.2.5.html
If the query param is '*' matches on any date will be returned.
If the query param starts with '-' matches on records before and including the date param will be returned.
If the query param ends with '-' matches on records on and after the date param will be returned.
If the query param contains '-' between two date params, records between and including the two dates will be returned.
Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12470
Review notes
Review checklist