Add the return key attributes as specified in the conformance doc#55
Open
Add the return key attributes as specified in the conformance doc#55
Conversation
The documentation says non-requested keys will be ignored, so we are safe to always return the full set for each item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A C-FIND request can specify which fields the SCP SOP instances in response should contain
The documentation says non-requested keys will be ignored, so we are safe to always return the full set for each item.
(there's a whole other page of data in the table above) see the conformance doc to check this PR.
Jira link
Part of https://nhsd-jira.digital.nhs.uk/browse/DTOSS-12471
Review notes
Review checklist