[PRMP-1588] Expedite journey prevent ingestion on incorrectly formatted ODS Codes#1181
Open
PedroSoaresNHS wants to merge 12 commits intomainfrom
Open
[PRMP-1588] Expedite journey prevent ingestion on incorrectly formatted ODS Codes#1181PedroSoaresNHS wants to merge 12 commits intomainfrom
PedroSoaresNHS wants to merge 12 commits intomainfrom
Conversation
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
kamenbachvarov-nhs
previously approved these changes
Mar 19, 2026
lambdas/tests/unit/services/test_bulk_upload_metadata_processor_service.py
Outdated
Show resolved
Hide resolved
SWhyteAnswer
previously approved these changes
Mar 19, 2026
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
dismissed stale reviews from SWhyteAnswer and kamenbachvarov-nhs
via
e08458b
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
had a problem deploying
to
development
GitHub Actions
Failure
PedroSoaresNHS
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
reviewed
Mar 20, 2026
| """Ensure the parent directory of the expedite file is a valid ODS code.""" | ||
| ods_code = Path(s3_object_key).parent.name | ||
|
|
||
| if not re.fullmatch(r"^[A-Z]\d{5}$", ods_code): |
Contributor
There was a problem hiding this comment.
Can move this logic to utils, so this can be reused
NogaNHS
previously approved these changes
Mar 20, 2026
kamenbachvarov-nhs
previously approved these changes
Mar 20, 2026
PedroSoaresNHS
dismissed stale reviews from kamenbachvarov-nhs and NogaNHS
via
a68b917
PedroSoaresNHS
temporarily deployed
to
development
GitHub Actions
Inactive
PedroSoaresNHS
temporarily deployed
to
development
GitHub Actions
Inactive
PedroSoaresNHS
temporarily deployed
to
development
GitHub Actions
Inactive
Code security issues foundView full details here. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: (https://nhsd-jira.digital.nhs.uk/browse/PRMP-1588)
Description
Add verification logic to prevent ingestion on incorrectly formatted ODS codes in expedite
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)Deploy - Sandbox- workflow run - TBCSANDBOX Full- Deploy feature branch to sandbox- workflow run - TBC