Open
Conversation
alexnuttall
reviewed
Mar 16, 2026
infrastructure/terraform/modules/backend-api/dynamodb_table_proof_requests.tf
Outdated
Show resolved
Hide resolved
alexnuttall
previously approved these changes
Mar 16, 2026
nicki-nhs
reviewed
Mar 16, 2026
nicki-nhs
reviewed
Mar 16, 2026
nicki-nhs
reviewed
Mar 16, 2026
infrastructure/terraform/modules/backend-api/module_sqs_proof_requests_table_events_pipe_dlq.tf
Outdated
Show resolved
Hide resolved
chris-elliott-nhsd
previously approved these changes
Mar 19, 2026
alexnuttall
reviewed
Mar 19, 2026
alexnuttall
reviewed
Mar 19, 2026
alexnuttall
approved these changes
Mar 19, 2026
chris-elliott-nhsd
approved these changes
Mar 19, 2026
nicki-nhs
reviewed
Mar 19, 2026
| }, | ||
| "additionalProperties": { | ||
| "type": "string" | ||
| } |
Contributor
There was a problem hiding this comment.
taking these out aren't we?
nicki-nhs
reviewed
Mar 19, 2026
| } | ||
| }, | ||
| "description": "Contact details to send the proof to" | ||
| } |
nicki-nhs
reviewed
Mar 19, 2026
| }, | ||
| "additionalProperties": { | ||
| "type": "string" | ||
| } |
nicki-nhs
reviewed
Mar 19, 2026
| }, | ||
| "email": { | ||
| "type": "string" | ||
| } |
nicki-nhs
reviewed
Mar 19, 2026
| }, | ||
| "additionalProperties": { | ||
| "type": "string" | ||
| } |
nicki-nhs
reviewed
Mar 19, 2026
| "properties": { | ||
| "sms": { | ||
| "type": "string" | ||
| }, |
nicki-nhs
reviewed
Mar 19, 2026
| templateType: z.literal('SMS').meta({ | ||
| description: 'Template type for the template being proofed', | ||
| }), | ||
| contactDetails: $ProofContactDetails.extend({ |
Contributor
There was a problem hiding this comment.
but doesnt this keep email as optional?
nicki-nhs
reviewed
Mar 19, 2026
| templateType: z.literal('NHS_APP').meta({ | ||
| description: 'Template type for the template being proofed', | ||
| }), | ||
| contactDetails: $ProofContactDetails.optional(), |
nicki-nhs
reviewed
Mar 19, 2026
| }), | ||
| }); | ||
|
|
||
| const $ProofContactDetails = z |
Contributor
There was a problem hiding this comment.
not sure if this is valuable like this is it? there's no scenario where we'd ever expect both, so should this be one or the other? or do we even need it?
nicki-nhs
reviewed
Mar 19, 2026
| templateType: z.literal('EMAIL').meta({ | ||
| description: 'Template type for the template being proofed', | ||
| }), | ||
| contactDetails: $ProofContactDetails.extend({ |
nicki-nhs
reviewed
Mar 19, 2026
| await proofRequestsStorageHelper.seed([ | ||
| { | ||
| id: proofRequestId, | ||
| owner: `CLIENT#${user.clientId}`, |
Contributor
There was a problem hiding this comment.
should this still be here?
nicki-nhs
reviewed
Mar 19, 2026
|
|
||
| export type DigitalProofRequest = { | ||
| id: string; | ||
| owner: string; |
nicki-nhs
reviewed
Mar 19, 2026
| /** | ||
| * Breaks a list into chunks of upto 25 items | ||
| */ | ||
| private static chunk<T>(list: T[], size = 25): T[][] { |
Contributor
There was a problem hiding this comment.
in case you haven't seen, Michael's PR has split this out into its own file, maybe could align the approach across both PRs so we don't end up with duplicates?
nicki-nhs
reviewed
Mar 19, 2026
| } | ||
| ); | ||
|
|
||
| it('fails when SMS proof request does not include contactDetails.sms', () => { |
Contributor
There was a problem hiding this comment.
what about the inverse?
fails when SMS proof contains email? email proof contains sms?
apap contains either? dont we expect those to fail too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.