Skip to content

Conversation

@RHammond2
Copy link
Collaborator

Fix Pytest v9 type enforcement and Jupyter-Book v2 migration issues

This PR fixes a user-facing bug in the pytest custom hooks for running the unit and regression test suite in isolation caused by the enforcement of list[args] typing adopted in pytest args. Additionally, the Jupyter Book version is capped at 1.x to avoid potential migration issues for v2.

PR Checklist

  • CHANGELOG.md has been updated to describe the changes made in this PR
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated
  • Tests pass (If not, and this is expected, please elaborate in the tests section)
  • PR description thoroughly describes the new feature, bug fix, etc.

Related issues

The pytest issue was found in a separate project, and reported in pytest-dev/pytest#13996.

Impacted areas of the software

  • tests/conftest.py
    • pytest_configure: Converts Path objects to str and sorts the tests alphabetically.
  • pyproject.toml: Pins jupyter-book to only use 1.x releases.

Additional supporting information

Python version: 3.12.9
WOMBAT version (wombat.__version__): 0.12.2

Test results, if applicable

Tests pass when run in isolation and together

@RHammond2 RHammond2 merged commit 6638dba into main Dec 1, 2025
11 checks passed
@RHammond2 RHammond2 deleted the patch/dependency-fixes branch December 1, 2025 20:37
RHammond2 added a commit that referenced this pull request Dec 23, 2025
* Patch: Fix Pytest and Jupter Book compatibility issues for latest releases (#230)

* update for args list[str] enforcement in v9

* pin jupyter-book prior to migration

* update changelog

* sort tests

* bump version

* add experimental lbw data

* adjust from other sources

* document land-based assumptions and add references to the refs.bib

* update v0.13 dataset changes

* update bibtex and partially update user guide

* update reference usage

* update bullet style

* udpate and restrucutre changelog

* add lbw weather file

* convert osw weather to pqt

* remove CSVs

* udpate configs

* update casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants