Skip to content

Notes on _nl_conll_ner.py#106

Open
LourensVeen wants to merge 1 commit intoNLeSC:masterfrom
LourensVeen:nl-conll-ner-notes
Open

Notes on _nl_conll_ner.py#106
LourensVeen wants to merge 1 commit intoNLeSC:masterfrom
LourensVeen:nl-conll-ner-notes

Conversation

@LourensVeen
Copy link
Member

See inline.


Returns an iterable over the lines of the concatenated dataset.
"""
return (ln for part in ["train", "testa", "testb"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets downloaded for every session now. Maybe it would be better if we made a local copy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's legally tricky.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, then so is downloading it in the first place, unless they have an unusual license. I'm planning to do a legal analysis of xtas anyway, so let's leave this for now and we'll figure it out as part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants