Implement retrieving dns servers in windows#518
Conversation
Currently the ResolvConf does only read the '/etc/resolv.conf' file to find the active DNS servers. This does not work on windows. In windows you can use the GetAdaptersAddresses win32 api function to find the required information.
68a86bb to
71af8a0
Compare
|
Thank you for the PR! First of all, apologies for the ridiculous delay in responding. We’ve been quite busy with Cascade and the unrelated parts of domain fell behind the couch. While the PR looks good, we feel a bit uncomfortable to add code with quite a bit of unsafe blocks for a system that we are not experienced with and only have limited testing capabilities. I had a quick look at what Hickory does and they seem to be using a crate called ipconfig which provides safe abstractions and, from a cursory look, seems well maintained even if it looks odd on docs.rs. So, I think I would prefer if we based the server discovery on Windows on that crate. I don’t know if you are interested in converting your PR to that or if you would rather we did the implementation. Once again, sorry for the delay! |
Currently the
ResolvConfdoes only read the '/etc/resolv.conf' file to find the active DNS servers. This does not work on windows. In windows you can use the GetAdaptersAddresses win32 api function to find the required information.