Conversation
mozzieongit
requested changes
Mar 23, 2026
|
|
||
| /// The type of queries for [`Ds`](crate::new::rdata::Ds) records. | ||
| pub const DS: Self = Self::new(43); | ||
|
|
Member
There was a problem hiding this comment.
Do we have a tracking issue of types that are not yet implemented by new base, but are by old base/planned? (I'm thinking of SSHFP for example, which we use in our zone)
Contributor
Author
There was a problem hiding this comment.
I've made #640, which I'll update once this PR is merged.
Contributor
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Only one question in addition to Jannik's comments.
Caught while defining 'ZoneMD'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves various minor limitations of
domain::new, as experienced in developing Cascade. In particular, it adds theZoneMDandRprecord types, with extensive documentation, and adds a number of useful RTYPEs and QTYPEs (even for record types that have not been defined yet).