Upload Portal: Simulation files from Markus S. Miettinen#178
Merged
Conversation
simulation-addition-helper
bot
had a problem deploying
to
user_data_addition
simulation-addition-helper
bot
had a problem deploying
to
user_data_addition
MagnusSletten
temporarily deployed
to
user_data_addition
GitHub Actions
Inactive
comcon1
reviewed
Jan 4, 2026
Comment on lines
+2
to
+7
| "M_G1_M M_G1H1_M": [ | ||
| [-0.0416091, 0.0266518, 0.00426771] | ||
| ], | ||
| "M_G1_M M_G1H2_M": [ | ||
| [-0.176968, 0.0335989, 0.00538013] | ||
| ], |
Member
There was a problem hiding this comment.
The same problem. We should decide what to do. My offer is that we merge and then fix mapping file together with all the JSONs all over the databank.
Collaborator
There was a problem hiding this comment.
With your description of the problem I think this approach makes sense. Doing specific work with this batch of simulations makes less sense if we're going to do similar general fixes across the databank anyways.
comcon1
approved these changes
Jan 5, 2026
This was referenced Jan 5, 2026
comcon1
pushed a commit
to NMRLipids/UserData
that referenced
this pull request
Jan 8, 2026
* Add info.yml from Markus S. Miettinen * Process info.yml [bot] --------- Co-authored-by: simulation-addition-admin[bot] <226149754+simulation-addition-admin[bot]@users.noreply.github.com> Co-authored-by: simulation-addition-admin[bot] <simulation-addition-admin[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains simulation files uploaded by @markussmiettinen through the NMRlipids upload portal.
Processing of simulation data will happen after approval.