Merged
Conversation
Collaborator
|
Nice! Number of errors are reduced quite a bit (44 ->15) . Bottom error can be ignored as it is wrong. |
Collaborator
These just a matter of moving step2_drude.psf from pdb to psf? |
Collaborator
|
We currently require pdb with openMM sims, but a lot of them only have psf. Guessing schema should be changed accordingly? i.e openMM require at least one of pdb or psf? |
Member
Author
Let's ask @batukav. He has added these systems. |
mdondrup
approved these changes
Jan 12, 2026
Collaborator
mdondrup
left a comment
There was a problem hiding this comment.
This looks good to me if it reduces the number of validation errors. Most of these changes are outside of what affects the front-end but will approve anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small fixes to