Adding ExperimentSchema check and experiment README update#289
Open
korbinib wants to merge 1 commit intoNMRLipids:mainfrom
Open
Adding ExperimentSchema check and experiment README update#289korbinib wants to merge 1 commit intoNMRLipids:mainfrom
korbinib wants to merge 1 commit intoNMRLipids:mainfrom
Conversation
Changes to be committed: new file: ../.github/workflows/CheckExperimentSchema.yml modified: README.md
Collaborator
MagnusSletten
left a comment
MagnusSletten
left a comment
There was a problem hiding this comment.
Looks great! Couple of minor comments.
Comment on lines
+29
to
+32
| - name: Install Databank dependencies | ||
| working-directory: Databank | ||
| run: | | ||
| pip install . |
Collaborator
There was a problem hiding this comment.
With your current use of json-schema you actually don't need a pip install here at all which is nice. Should be very fast.
Comment on lines
+41
to
+42
| if [ -f "$file" ]; then | ||
| check-jsonschema --schemafile ../Databank/src/fairmd/lipids/schema_validation/schema/experiment_schema.json "$file" |
Collaborator
There was a problem hiding this comment.
With the smaller number of experiment files to check I think this will be perfectly fine, but it uses a new python process for each file.
Something like
find ./experiments -type f -name README.yaml -print0 \
| xargs -0 -r check-jsonschema \
--schemafile ../Databank/src/fairmd/lipids/schema_validation/schema/experiment_schema
Will be even faster because it reuses the process. This was more relevant for the simulation readme files though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
new file: ../.github/workflows/CheckExperimentSchema.yml
modified: README.md
Fixes partly NMRLipids/FAIRMD_lipids#459