Merged
Conversation
… freeplay-rewrite
… freeplay-rewrite
… bit up to look better
Contributor
Author
|
please speed |
|
Please speed I neeeed this. My Freeplay's kinda tabless.... |
mark them as potentially nullable and use json5 parsing
improve the cleanup only show tabHint if there is more than 1 tab
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty rough implementation of Freeplay tabs.
Tabs are defined in the a
data/freeplay.jsonfile with the following format:{ "tabs": [ { "title": "Tab Title", "songs": ["song-one", "song-two", "song-three"] } ] }If there are no tabs defined - The engine resorts back to old Freeplay behaviour and creates it using weeks instead.
Tabs can be scrolled through by pressing TAB. Holding shift makes you scroll backwards.
You may notice that none of the songs have icons:

That's because icon, bg color and display name for songs should be defined in the song's
meta.jsonfile like this:{ "songName": "dadbattle", "displayName": "Dad Battle", "freeplayColor": "#9457EB", "freeplayIcon": "dad" }If this gets merged I'll personally go through every single base game song and add metadata to them.
Edit: And i did.
Let me know if anything should be changed.