Compile GSI-monitor within Ubuntu Intel with spack stack 1.9.2 container#201
Open
weihuang-jedi wants to merge 6 commits intoNOAA-EMC:developfrom
Open
Compile GSI-monitor within Ubuntu Intel with spack stack 1.9.2 container#201weihuang-jedi wants to merge 6 commits intoNOAA-EMC:developfrom
weihuang-jedi wants to merge 6 commits intoNOAA-EMC:developfrom
Conversation
4 tasks
RussTreadon-NOAA
requested review from
DavidHuber-NOAA,
EdwardSafford-NOAA and
RussTreadon-NOAA
Collaborator
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
I do not use the container. Thus, I can not test this PR. Please confirm the proposed changes work as intended without any adverse impact on non-container machines.
Collaborator
|
The GCC Linux Build / setup and Intel Linux Build / setup failures introduced by 0de78b2 need to be corrected. These tests should not fail. |
Contributor
Author
|
Thanks @RussTreadon-NOAA and @DavidHuber-NOAA for reviewing this PR. I'll wait and also do some test on the issues as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Global-Workflow for GFS compiles and runs with Ubuntu Intel with Spack-stack-1.9.2 container, want to make GSI-Monitor compile with this container as well.
This PR make GSI-monitor compile with such container, and resolve issue #200