Add new gust factor to HAFS products #1422
Conversation
KarinaAsmar-NOAA
requested review from
BenjaminBlake-NOAA and
WenMeng-NOAA
as code owners
Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
sorc/ncep_post.fd/MDL2P.f
Outdated
| real, dimension(ISTA_2L:IEND_2U,JSTA_2L:JEND_2U,LSM) :: TPRS, QPRS, FPRS | ||
| real, dimension(ISTA_2L:IEND_2U,JSTA_2L:JEND_2U,LSM) :: RHPRS | ||
| real, dimension(ista_2l:iend_2u,jsta_2l:jend_2u) :: CHI, PSI | ||
| real, dimension(ista_2l:iend_2u,jsta_2l:jend_2u) :: WS850, WS950, GUSTCONV |
There was a problem hiding this comment.
@KarinaAsmar-NOAA Suggest these new variables are declared as allocatable to to reduce memory usage.
There was a problem hiding this comment.
The new test with these changes are in /scratch4/NCEPDEV/ovp/Karina.Asmar/hafs_2022092800_allocate. Same stats as before:
3:2977237:ndata=2287841:undef=681148:mean=6.62765:min=0:max=79.5:cos_wt_mean=6.51753 (old gust)
688:743853124:ndata=2287841:undef=681148:mean=6.34466:min=0.2:max=79.6:cos_wt_mean=6.25535 (hafs gust)
|
@AndrewHazelton There is an issue inviting you as reviewer. You are welcome to comment on this PR. Thanks for contributing to R2O in UPP. |
Thanks for finding this, I'll check on it. |
@BenjaminBlake-NOAA This should be fixed now. Please see /scratch4/NCEPDEV/ovp/Karina.Asmar/hafs_2022092800_fixed_0mb. |
|
@KarinaAsmar-NOAA I re-ran my HAFS test and the extra fields are now removed - thanks for addressing this so quickly. |
Add new gust factor to HAFS products NOAA-EMC#1422 The CIMAS/AOML/HRD team has developed a new gust factor as part of HAFS development. This PR implements the new calculations into the UPP source code and adds the new GUST ID to the HAFS products list.
|
@BinLiu-NOAA Thanks for reviewing. We will proceed with the final UPP RTs. Do you have any additional comments? |
|
@WenMeng-NOAA Looks good from my end. Thanks to @KarinaAsmar-NOAA for making those formatting and removing trailing whitespace changes! |
|
@clyden-noaa This PR is ready for the UPP RTs on R&D machines. There should be baseline changes expected for the hafs test only. For your reference, my testing on Ursa is available: |
WenMeng-NOAA
added
the
Baseline Change
Add new gust factor to HAFS products NOAA-EMC#1422 The CIMAS/AOML/HRD team has developed a new gust factor as part of HAFS development. This PR implements the new calculations into the UPP source code and adds the new GUST ID to the HAFS products list.
8 participants
The CIMAS/AOML/HRD team has developed a new gust factor as part of HAFS development. This PR implements the new calculations into the UPP source code and adds the new GUST ID to the HAFS products list. Resolves #1389 . The corresponding test results are in Ursa: /scratch4/NCEPDEV/ovp/Karina.Asmar/hafs_2022092800. The run script is /scratch4/NCEPDEV/ovp/Karina.Asmar/UPP/submit_run_hafs_ursa.sh.