Skip to content

Fix cross-year data combination overwrite issue#116

Open
mingchen-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
mingchen-NOAA:bug/fixCrossYearOW
Open

Fix cross-year data combination overwrite issue#116
mingchen-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
mingchen-NOAA:bug/fixCrossYearOW

Conversation

@mingchen-NOAA
Copy link
Copy Markdown
Contributor

Pull Request Summary

This PR addresses the issue when combining interpolated satellite matchup data across a time range that spans multiple calendar years, the output files are unintentionally overwritten.

Description

This PR resolves the cross-year data combination overwrite issue by:

  1. Removing SELECTED_YEAR, which caused data from one year to overwrite another. The combination period is now controlled solely by startdate and enddate.
  2. Add an optional INPUTDIR_BASE parameter, allowing users to specify the directory for interpolated input data. This removes the requirement for source data to reside under WORKDIR, improving flexibility for team workflows. The default remains WORKDIR/processsatdata/outinterp.
  3. Updating the corresponding Slurm jobcard generation script to support the new option.

Issue(s) addressed

fixes #109

Commit Message

Address cross-year data combination overwrite issue

Check list

  • Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.

Testing

  • How were these changes tested?
    The updated scripts can be tested on Orion using the current settings.
    My tests are at /work2/noaa/marine/ming.chen/issue109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross-year data combination overwrites output files for same season

1 participant