Skip to content

Conversation

weihuang-jedi
Copy link
Contributor

Description

While working on containerized GW, we have found that some network settings will significantly/dramatically improve GW forecast timing at high-resolution. Want to apply those changes to GW before the container code is reviewed.

Resolves #4122

Type of change

  • Bug fix (fixes something broken)
  • [ x] New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • C48_S2SW, and C768_S2SW test on Ursa and GaeaC6

Checklist

  • Any dependent changes have been merged and published
  • [ x] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • [x ] My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.
Only thing to test/check here is if these blocks also improve runtime of the GSI, JEDI executables.

@JessicaMeixner-NOAA
Copy link
Contributor

@weihuang-jedi - what is your definition of high resolution in this case?

@weihuang-jedi
Copy link
Contributor Author

I have not run GSI, JEDI before, and from the the tests I did, it improves performance of high-resolution.
Hope someone at GSI, and JEDI group can do some tests with their high-resolution cases.

@JessicaMeixner-NOAA
Copy link
Contributor

While not a clean test because the two runs used different spack-stacks, but using the updates suggested here, the same configuration of C1152 S2SW forecast went from 11433.912819 to 4086.673683 seconds. Thank you @weihuang-jedi !! This is awesome!

@weihuang-jedi
Copy link
Contributor Author

@JessicaMeixner-NOAA Thank you very much for testing it out, and glad to see the similar runtime improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve GW performance of high-resolution runs with findings from containerized GW
3 participants