Draft
Conversation
- Created abstract types for core coupler functionality - Refactored original coupler types to extend the new abstract types - Implemented type-bound getter functions for all coupler types
- Implemented type-bound getter methods for all public drifter types - No changes to type hierarchy; existing types remain unchanged
- Implemented type-bound getter methods for all public horiz_interp types - No changes to type hierarchy; existing types remain unchanged
- Implemented type-bound getter methods for all public random_numbers types - No changes to type hierarchy; existing types remain unchanged
Fixed some get type-bound functions for coupler_bc_types
Contributor
|
@abrooks1085 Is this ready to go in? Looks like its passing all the CI but is still set to a draft. |
Contributor
|
@abrooks1085 Is this going to be ready today/tomorrow or do you need more time? |
Contributor
Author
|
I’ll need more time
…On Thu, Sep 4, 2025 at 12:03 PM uramirez8707 ***@***.***> wrote:
*uramirez8707* left a comment (NOAA-GFDL/FMS#1682)
<#1682 (comment)>
@abrooks1085 <https://github.com/abrooks1085> Is this going to be ready
today/tomorrow or do you need more time?
—
Reply to this email directly, view it on GitHub
<#1682 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBHG7EZG4JDKJEGZR5UNDCT3RBPDRAVCNFSM6AAAAAB3LDRP5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENJUGQZDAMBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds type-bound getters/setters for public derived types in FMS
#1691
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses