Conversation
Added log upload step for distcheck failures.
rem1776
requested review from
bensonr,
uramirez8707 and
vithikashah001
as code owners
…d use internal action for deps
8 tasks
uramirez8707
approved these changes
Apr 13, 2026
Contributor
uramirez8707
left a comment
uramirez8707
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the update, Ryan.
| DISTCHECK_CONFIGURE_FLAGS: "${{ matrix.conf-flag }} ${{ matrix.input-flag }} ${{ matrix.io-flag }}" | ||
| DISTCHECK_CONFIGURE_FLAGS: "${{ matrix.conf-flag }} ${{ matrix.input-flag }}" | ||
| DEBUG_FLAGS: "-O0 -g -fbounds-check -ffpe-trap=invalid,zero,overflow" # debug compiler flags taken from the mkmf template | ||
| # diag manager openmp + logical mask tests fail with gcc, these are reproducible outside the CI |
Contributor
There was a problem hiding this comment.
Can you open up an issue for this so we can track it and fix it?
Contributor
Author
There was a problem hiding this comment.
yeah i thought we had one open already, but i guess not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the CI image to use a new stack with gnu 15.1.0 and updated versions for netcdf (4.9.3 c/ 4.6.2 fortran), hdf5 (1.14.6), and mpich (4.3.2).
Arm/spack can't seem to build gcc 15.1.0, so for now I just rebuilt the old image on arm with an updated cmake for nvidia support.
There's some other CI changes as well, the workflows were updated for more uniform naming scheme and they will have less output, just showing failed tests and uploading the full log on failures.
This also includes a couple fixes to better support openmpi, which mostly means adding fms_end calls in tests to close out mpi correctly and adjusting the build systems to allow for a different --oversubscribe flag.
How Has This Been Tested?
CI
Checklist:
make distcheckpasses