Generalized indices: mpp_group_update#1853
Open
J-Lentz wants to merge 8 commits intoNOAA-GFDL:mainfrom
Open
Conversation
added 4 commits
March 30, 2026 14:15
Rough draft of generalized indices for group_update
- Inline `group_assign_bounds` - Replace `mpi_get_address` with `c_loc`
Calculate the indices of the original array from (i,j,k), instead of looping over all lower values of k.
J-Lentz
requested review from
bensonr,
rem1776,
uramirez8707 and
vithikashah001
as code owners
uramirez8707
reviewed
Apr 1, 2026
Contributor
uramirez8707
left a comment
uramirez8707
left a comment
There was a problem hiding this comment.
Just some minor comments, but it looks good!
added 3 commits
April 2, 2026 12:10
Store result of `c_loc()` in a temporary variable before passing it to `c_f_pointer`. This is needed because `call c_f_pointer(c_loc(...), ...)` doesn't work with GFortran.
uramirez8707
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
mpp_group_updateto work with non-standard index orders. This update introduces new logic into inner packing loops, which could be a potential source of performance regressions.How Has This Been Tested?
Builds with ifx 2025.2.1 on C5, and unit tests pass. Must be tested for performance.
Checklist:
make distcheckpasses