Cell measures final fix#1854
Merged
vithikashah001 merged 3 commits intoNOAA-GFDL:mainfrom Apr 6, 2026
Merged
Conversation
vithikashah001
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is completely fixes the cell measures issues from previous versions of FMS
The problem was that the
var_output_namevariable was not being defined whenever this if statement is true.FMS/diag_manager/fms_diag_field_object.F90
Line 2023 in df64d67
This will happen if multiple variables have the same area. The first time
var_output_namewill be defined correctly, but the second time that if statement will be true, leading to undefined behavior.Fixes #1842
How Has This Been Tested?
CI, including new test (the test fails without this update as expected)
ESM4.5 has been running with the 6f9ad52 commit
Checklist:
make distcheckpasses