Skip to content

Cell measures final fix#1854

Merged
vithikashah001 merged 3 commits intoNOAA-GFDL:mainfrom
uramirez8707:cell_measures_final_fix
Apr 6, 2026
Merged

Cell measures final fix#1854
vithikashah001 merged 3 commits intoNOAA-GFDL:mainfrom
uramirez8707:cell_measures_final_fix

Conversation

@uramirez8707
Copy link
Copy Markdown
Contributor

Description
This is completely fixes the cell measures issues from previous versions of FMS

The problem was that the var_output_name variable was not being defined whenever this if statement is true.

if (index(att, field_name) .ne. 0) return

This will happen if multiple variables have the same area. The first time var_output_name will be defined correctly, but the second time that if statement will be true, leading to undefined behavior.

Fixes #1842

How Has This Been Tested?
CI, including new test (the test fails without this update as expected)
ESM4.5 has been running with the 6f9ad52 commit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Copy link
Copy Markdown
Contributor

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vithikashah001 vithikashah001 merged commit 2b89e6f into NOAA-GFDL:main Apr 6, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG - MODERN DIAG MANAGER cell measures and associated files attributes are not defined correctly

3 participants