mpp_define_mosaic: Support Case where tile_id(1)>1#1856
Open
J-Lentz wants to merge 2 commits intoNOAA-GFDL:mainfrom
Open
mpp_define_mosaic: Support Case where tile_id(1)>1#1856J-Lentz wants to merge 2 commits intoNOAA-GFDL:mainfrom
mpp_define_mosaic: Support Case where tile_id(1)>1#1856J-Lentz wants to merge 2 commits intoNOAA-GFDL:mainfrom
Conversation
Currently, when a caller-defined `tile_id` list is passed to `mpp_define_mosaic`, it only works when the lowest tile ID in the list is 1. These changes add support for the case where the first tile ID is an integer greater than 1.
Contributor
|
@J-Lentz - the comments at lines 1197-1198 address this issue. Either update the comments or use the suggested variable name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a caller-defined
tile_idlist is passed tompp_define_mosaic, it only works when the lowest tile ID in the list is 1. These changes add support for the case where the first tile ID is an integer greater than 1.How Has This Been Tested?
Builds with ifx on C5, and fixes various array bounds errors in
mpp_define_mosaicin my test case.Checklist:
make distcheckpasses