Skip to content

mpp_define_mosaic: Support Case where tile_id(1)>1#1856

Open
J-Lentz wants to merge 2 commits intoNOAA-GFDL:mainfrom
J-Lentz:mpp_define_mosaic
Open

mpp_define_mosaic: Support Case where tile_id(1)>1#1856
J-Lentz wants to merge 2 commits intoNOAA-GFDL:mainfrom
J-Lentz:mpp_define_mosaic

Conversation

@J-Lentz
Copy link
Copy Markdown
Contributor

@J-Lentz J-Lentz commented Apr 9, 2026

Description
Currently, when a caller-defined tile_id list is passed to mpp_define_mosaic, it only works when the lowest tile ID in the list is 1. These changes add support for the case where the first tile ID is an integer greater than 1.

How Has This Been Tested?
Builds with ifx on C5, and fixes various array bounds errors in mpp_define_mosaic in my test case.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Currently, when a caller-defined `tile_id` list is passed to
`mpp_define_mosaic`, it only works when the lowest tile ID in the list
is 1. These changes add support for the case where the first tile ID is
an integer greater than 1.
@bensonr
Copy link
Copy Markdown
Contributor

bensonr commented Apr 13, 2026

@J-Lentz - the comments at lines 1197-1198 address this issue. Either update the comments or use the suggested variable name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants