Scale tideamp to L/T instead of Z/T

[breichl]

• Setting BBL_USE_TIDAL_BG = True causes the model to fail dimensional consistency test. If you set the spatial scale as m_to_L instead of m_to_Z in MOM_set_viscosity it fixes the issue.

[Hallberg-NOAA]

I have examined the code related to this change, and I agree with it, but the comment describing the units of CS%tideamp on line 136 of MOM_set_viscosity.F90 also need to be corrected, from [Z T-1 ~> m s-1] to [L T-1 ~> m s-1].

[breichl]

Got it. Thanks for looking at this and catching that, @Hallberg-NOAA!

[Copilot]

Pull request overview

Fixes a dimensional-scaling inconsistency when BBL_USE_TIDAL_BG = True by ensuring tidal amplitude input is scaled as a horizontal velocity (L/T) rather than a vertical velocity (Z/T), resolving the dimensional consistency test failure described in the PR.

Changes:

• Update tideamp units annotation to [L T-1] to reflect a horizontal velocity.
• Rescale tideamp input read from US%m_to_Z*US%T_to_s to US%m_to_L*US%T_to_s in set_visc_init.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[adcroft]

Tested and passed at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/30583.

Handling merge on the command line so we can avoid a modified commit message

[adcroft]

Thie PR was merged manually in c925265