add diag_manager monitor class and unit tests#427
Open
rem1776 wants to merge 3 commits intoNOAA-GFDL:developfrom
Open
add diag_manager monitor class and unit tests#427rem1776 wants to merge 3 commits intoNOAA-GFDL:developfrom
rem1776 wants to merge 3 commits intoNOAA-GFDL:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new monitor class that utilizes the diagnostic manager from the FMS fortran library, via the pyFMS python interfaces.
This aims to match up with the existing netcdf monitor object, with the major differences being that fields and axis will need to be explicitly registered. Additionally, the diag monitor can perform a number of reductions on the sent in data such as averaging or taking min/max from what is sent in. These are defined in the diag_table.yaml file, which are created in the test scripts.
One caveat is any written data will be transposed since it is being written from the fortran side.
How has this been tested?
Tested with the added unit tests
Checklist