Clarify tprcp variable comment with units#82
Open
JosephMouallem wants to merge 1 commit intoNOAA-GFDL:mainfrom
Open
Clarify tprcp variable comment with units#82JosephMouallem wants to merge 1 commit intoNOAA-GFDL:mainfrom
JosephMouallem wants to merge 1 commit intoNOAA-GFDL:mainfrom
Conversation
Updated comment for tprcp to specify units in meters or kg/m^2.
laurenchilutti
approved these changes
Mar 30, 2026
Member
laurenchilutti
left a comment
laurenchilutti
left a comment
There was a problem hiding this comment.
I'm trusting that you have the correct units
Member
|
@vithikashah001 This is ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated comment for
tprcpto specify units inmetersorkg/m^2 * 1e-3.This field
IPD_Data(nb)%Sfcprop%tprcpis then passed to the full coupler and converted tokg/m^2by*1000in atmos_drivers.