Fix unpack_ocean_ice_boundary_calved_shelf_bergs #252
Merged
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom Mar 24, 2026
Merged
Fix unpack_ocean_ice_boundary_calved_shelf_bergs #252Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Hallberg-NOAA merged 2 commits intoNOAA-GFDL:dev/gfdlfrom
Conversation
In subroutine unpack_ocean_ice_boundary_calved_shelf_bergs, corrected FIA%calving and FIA%calving_hflx so that they are on slow-ice PEs, as called from the coupler (this type of calving comes from MOM6-IS). Also made change to allow calving in a cell to accumulate from both ice-sheet flux and land model frozen runoff, as there are cases where this should be possible.
Hallberg-NOAA
force-pushed
the
fix_OIB_calved_bergs
branch
from
a542f30 to
38b8d5b
Compare
Member
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/SIS2/-/pipelines/30379. |
Hallberg-NOAA
approved these changes
Mar 24, 2026
Member
Hallberg-NOAA
left a comment
Hallberg-NOAA
left a comment
There was a problem hiding this comment.
These changes seem to me to be correct. It should be noted that this routine in not being called yet, although it will be once a pending PR to the FMS coupler (NOAA-GFDL/FMScoupler#147) is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In subroutine unpack_ocean_ice_boundary_calved_shelf_bergs, corrected FIA%calving and FIA%calving_hflx so that they are on slow-ice PEs, as called from the coupler (this type of calving comes from the ice shelf on the MOM6 grid).
Also made changes to allow calving in a cell to accumulate from both ice-sheet flux and land model frozen runoff, as there are cases where this should be possible.