Skip to content

Stochastic physics changes#70

Open
MingjingTong-NOAA wants to merge 4 commits intoNOAA-GFDL:mainfrom
MingjingTong-NOAA:shield_da_merge
Open

Stochastic physics changes#70
MingjingTong-NOAA wants to merge 4 commits intoNOAA-GFDL:mainfrom
MingjingTong-NOAA:shield_da_merge

Conversation

@MingjingTong-NOAA
Copy link
Copy Markdown

Description
This is part of the changes to update the use of stochastic physics from a new and updated repo

How Has This Been Tested?
A forecast test was run to compare with the main branch and the results are bit-wise identical.

Checklist:

  • [x ] My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [x ] Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@laurenchilutti
Copy link
Copy Markdown
Member

Is this still a draft or ready for a review?

@MingjingTong-NOAA MingjingTong-NOAA marked this pull request as ready for review March 10, 2026 14:26
@MingjingTong-NOAA
Copy link
Copy Markdown
Author

Sorry, I change it to be ready to review. Thanks.

Comment thread SHiELD/atmos_model.F90
logical :: debug = .false.
logical :: sync = .false.
logical :: first_time_step = .false.
logical :: write_first_time_step = .false.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for this name change? I would prefer keeping the current name to avoid having to update all of our runscripts.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change the name, because I introduced another 'first_time_step' variable in physics here

./GFS_layer/GFS_typedefs.F90: logical :: first_time_step !< flag signaling first time step for time integration routine

This variable is used in the atmos_model.F90

./atmos_model.F90: IPD_control%first_time_step = .false.
./atmos_model.F90: IPD_control%first_time_step = .true.

Also, I think write_first_time_step better indicates the meaning of this variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants