Skip to content

call to populate surf_diff for implicit coupling #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JosephMouallem wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −26
Open

call to populate surf_diff for implicit coupling #71

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e716d37
call to populate surf_diff which is moved elsewhere
JosephMouallem Mar 27, 2026
c5e8adb
re-enable land feedback
JosephMouallem Apr 14, 2026
268ca10
cosmetic
JosephMouallem Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 16 additions & 26 deletions SHiELD/atmos_model.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ module atmos_model_mod
use atmosphere_mod, only: atmosphere_coarse_diag_axes
use atmosphere_mod, only: atmosphere_coarsening_strategy
use atmosphere_mod, only: Atm, mygrid
use atmosphere_mod, only: populate_surf_diff, land_feedback, surf_diff_type
use block_control_mod, only: block_control_type, define_blocks_packed
use IPD_typedefs, only: IPD_init_type, IPD_control_type, &
IPD_data_type, IPD_diag_type, &
Expand Down Expand Up @@ -124,29 +125,6 @@ module atmos_model_mod
public atm_stock_pe
!-----------------------------------------------------------------------

!<PUBLICTYPE >
! FROM AM4/src/atmos_phys/atmos_param/vert_diff/vert_diff.F90
! Surface diffusion derived type data
type surf_diff_type

real, pointer, dimension(:,:) :: dtmass => NULL(), & !dt / mass (mass of lower atmospheric layer)
dflux_t => NULL(), & ! temperature flux derivative at the top of the lowest atmospheric
! layer with respect to the temperature of that layer (J/(m2 K))
delta_t => NULL(), & ! the increment in temperature in the lowest atmospheric layer
delta_u => NULL(), & ! same for u
delta_v => NULL() ! same for v
real, pointer, dimension(:,:,:) :: tdt_dyn => NULL(), & ! no explanation found in the vert_diff.F90
qdt_dyn => NULL(), &! no explanation found in the vert_diff.F90
dgz_dyn => NULL(), &! no explanation found in the vert_diff.F90
ddp_dyn => NULL(), &! no explanation found in the vert_diff.F90

tdt_rad => NULL() !miz

real, pointer, dimension(:,:,:) :: dflux_tr => NULL(),& ! tracer flux tendency
delta_tr => NULL() ! tracer tendency
end type surf_diff_type
!<PUBLICTYPE >

!<PUBLICTYPE >
type atmos_data_type
! Atmosphere related variables
Expand Down Expand Up @@ -372,7 +350,7 @@ subroutine update_atmos_model_down( Surface_boundary, Atmos )
!
!-----------------------------------------------------------------------

type(land_ice_atmos_boundary_type), intent(in) :: Surface_boundary
type(land_ice_atmos_boundary_type), intent(inout) :: Surface_boundary
type (atmos_data_type), intent(inout) :: Atmos
integer :: nb

Expand Down Expand Up @@ -419,6 +397,16 @@ subroutine update_atmos_model_down( Surface_boundary, Atmos )
!--------------------------------------------------------------------------------------------
!--------------------------------------------------------------------------------------------

Comment thread
JosephMouallem marked this conversation as resolved.
!--------------------------------------------------------------------------------------------
!--------------------------------------------------------------------------------------------
! after the downward sweep, populate these quantities in atmos%surf_diff
! used in flux_down_from_atmos for implicit coupling ! Joseph
!--------------------------------------------------------------------------------------------
!--------------------------------------------------------------------------------------------
if (mpp_pe() == mpp_root_pe() .and. debug) write(6,*) "Populate surf_diff for implicit coupling"
call populate_surf_diff ( Atmos%surf_diff, IPD_Data, IAU_Data, Atm_block)
!call update_surface_boundary_from_down (Surface_boundary, IPD_Data, IAU_Data, Atm_block)

call mpp_clock_end(shieldClock)
call mpp_set_current_pelist() !should exit with global pelist to accomodate the full coupler atmos clock

Expand Down Expand Up @@ -473,9 +461,10 @@ subroutine update_atmos_model_up( Surface_boundary, Atmos )
call set_atmosphere_pelist() ! should be called before local clocks since they are defined on local atm(n)%pelist
call mpp_clock_begin(shieldClock)

!Atmos%Surf_diff%delta_t = Surface_boundary%dt_t
!Atmos%Surf_diff%delta_tr = Surface_boundary%dt_tr
Atmos%Surf_diff%delta_t = Surface_boundary%dt_t
Atmos%Surf_diff%delta_tr = Surface_boundary%dt_tr

call land_feedback ( Atmos%surf_diff, IPD_Data, IAU_Data, Atm_block)
!--- execute the IPD atmospheric physics step1 subcomponent (main physics driver)
call mpp_clock_begin(physClock)
!$OMP parallel do default (none) &
Expand Down Expand Up @@ -1306,6 +1295,7 @@ subroutine apply_fluxes_from_IPD_to_Atmos ( Atmos )

! cosine of zenith angle
Atmos%coszen(i,j) = IPD_Data(nb)%Coupling%coszena(ix)
!Atmos%coszen(i,j) = IPD_Data(nb)%Radtend%coszen(ix) ! use this for land coupling

! visible only
Atmos%flux_sw_down_vis_dir(i,j) = visbmd ! downward visible sw flux at surface - direct
Expand Down