[Feature] Allow N tracers (+ re-orchestration)#137
Draft
FlorianDeconinck wants to merge 20 commits intoNOAA-GFDL:developfrom
Draft
[Feature] Allow N tracers (+ re-orchestration)#137FlorianDeconinck wants to merge 20 commits intoNOAA-GFDL:developfrom
FlorianDeconinck wants to merge 20 commits intoNOAA-GFDL:developfrom
Conversation
Rework `Remapping` code, translate tests and subcomponents to fit the new `tracers`
…nd residency). This is to deal with the `no memoryview` feature of 3.12+
Workaround for limited halo exchange behavior Complete expected tracers for new FVDyn code Clean up
Make tracers access via direct slicing (instead) Fix `zero_qs` to be proper zero (use Quantity instad of Local) Fix bad merge in `MapNTracers`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Original AI2 port has not solve an unlimited number of tracers like the original FV can do. The main reason was that there was not a way to define Data Dimensions dynamically. With the introduction of DataDimensionFields this is solved.
Fixes # (issue)
If this is a hotfix to a released version, please specify it
How Has This Been Tested?
Translate tests
Checklist