refactor: use new versions of environment variables#84
Merged
fmalatino merged 2 commits intoNOAA-GFDL:developfrom Sep 16, 2025
Merged
refactor: use new versions of environment variables#84fmalatino merged 2 commits intoNOAA-GFDL:developfrom
fmalatino merged 2 commits intoNOAA-GFDL:developfrom
Conversation
The old ones are currently deprecated and expected to be removed in the future (after a grace period).
fmalatino
previously approved these changes
Sep 12, 2025
oelbert
previously approved these changes
Sep 15, 2025
Collaborator
Author
|
This should be good to merge now that NOAA-GFDL/pySHiELD#60 has landed. Can someone with access rights push the button? Thanks! 🙏 |
Collaborator
Author
|
@fmalatino I noticed you also tried to re-run the pyshield test. Re-running (and I always forget this) will re-run the test as it ran last time, meaning it will go and fetch the old version of pyshield (the one that doesn't have the patch yet). Are the failing pyshield tests blocking you from putting that PR into the merge queue? If so, I can force update the PR to trigger a new run of the pyshield tests (which will include your fixes and should thus pass). If not, I suggest you just put it into the merge queue because the merge queue will trigger tests again (with the new version of pyshield this time). |
Collaborator
Author
fmalatino
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
The old ones are currently deprecated and expected to be removed in the future (after a grace period). See NOAA-GFDL/NDSL#193 for more details.
How Has This Been Tested?
All good as long as CI is still green.
Checklist: