Revert "Physics state initialization fix"#42
Merged
fmalatino merged 1 commit intoNOAA-GFDL:developfrom Aug 14, 2025
Merged
Conversation
Collaborator
Author
|
@oelbert I can't assign reviewers in this repo, so here's a manual ping ... |
oelbert
approved these changes
Aug 14, 2025
Collaborator
oelbert
left a comment
There was a problem hiding this comment.
We do need to get this back in once we've figured out the problem :/
Collaborator
Author
Let have a follow-up issue: #43 PS: I also can't merge, so feel free to push the button. Or - try your hotfix NOAA-GFDL/pace#134 with updating the |
Collaborator
|
I don't quite have the bandwidth for it at this moment, but I'll try to get to it when I do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like
pacetests are broken with the current version ofPySHiELDphysics. We tracked it down to the last (merge) commit. This PR reverts #38, which brings things back into a working condition.Initial work to fix this in pace (see NOAA-GFDL/pace#134) didn't work out of the box.
Looks like the error crept in because of a stale/outdated CI run on the PR. Once we have the merge queue (e.g. PR #41) in place, we won't have this problem anymore.
How Has This Been Tested?
Running CI doesn't fail pace main tests as it does for #41.
Checklist: