Conversation
oelbert
left a comment
oelbert
left a comment
There was a problem hiding this comment.
Should we be referring to your forks in the github workflows and .toml or the NOAA-GFDL ones?
| jobs: | ||
| pace_unit_tests: | ||
| uses: NOAA-GFDL/pace/.github/workflows/main_unit_tests.yaml@develop | ||
| uses: floriandeconinck/pace/.github/workflows/main_unit_tests.yaml@update/numpy_2x |
There was a problem hiding this comment.
I assume we switch this back once we have a Pace PR in?
There was a problem hiding this comment.
Yes, sorry I should have put that in the PR.
We are going up and down the repos to make sure everything keeps green. So once Pace is updated, we will go back down and re-hook develop
| with: | ||
| submodules: 'recursive' | ||
| repository: NOAA-GFDL/pySHiELD | ||
| repository: floriandeconinck/PySHiELD |
There was a problem hiding this comment.
Don't think this is intended?
There was a problem hiding this comment.
It is - it's for the other repositories calling in.
There was a problem hiding this comment.
You don't like my pre-xumpy hack?
There was a problem hiding this comment.
I loved it. It broke numpy 2 :)
2 participants
Description
🧱 🧱 Merge post- NOAA-GFDL/NDSL#389 🧱 🧱NDSL
numpyupgrade to 2x brings a few changesnumpy>=2- we mirror the requirement here forRRTMGPndsl.types.NumpyModule, it was only used for access tonp.s_which id transparent to numpy/cupy