Move Dataset classes to dmod.core package#199
Merged
christophertubbs merged 15 commits intoNOAA-OWP:masterfrom Oct 20, 2022
Merged
Move Dataset classes to dmod.core package#199christophertubbs merged 15 commits intoNOAA-OWP:masterfrom
christophertubbs merged 15 commits intoNOAA-OWP:masterfrom
Conversation
Move module and its Dataset, DatasetType, (abstract) DatasetManager, and DatasetUser classes to dmod.core, as these classes are likely needed in a variety of places where the full modeldata package is not (e.g., the GUI).
Moving unit tests for Dataset to dmod.core after class moved to this package.
Adding __init__.py to correct issue with unit tests not always being loaded correctly.
Also removing class member _SERIALIZED_OBJ_NAME_TEMPLATE that is now located in superclass.
Bump dependency on dmod.core to 0.3.0 and on dmod.modeldata to 0.9.0.
Contributor
Author
christophertubbs
approved these changes
Oct 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the
Datasetclass and closely related, co-dependency types from dmod.modeldata to dmod.core to facilitate use of those classes in other places, in particular certain parts of the client and GUI.