Support for alternate data formats#299
Merged
robertbartel merged 4 commits intoNOAA-OWP:masterfrom Jun 12, 2023
Merged
Conversation
aaraney
previously approved these changes
Mar 20, 2023
Member
aaraney
left a comment
aaraney
left a comment
There was a problem hiding this comment.
Looks good to me! All I would ask is to open an issue to track adding tests to this area of the code in the future!
robertbartel
force-pushed
the
f/alternate_data_formats/isolated
branch
2 times, most recently
from
1b10e8b to
4c3b081
Compare
Adding DataFormat.can_format_fulfill class method to test if alternative data format is compatible, and updating logic of DataDomain.contains method to test and account for this type of compatibility.
Updating dmod.dataservice to depend on updated dmod.core (>=0.8.0).
Updating service manager find_dataset_for_requirement method to account for potentially compatible alternative dataset formats and examine any datasets having such formats if there are no matches with exactly the specified format.
robertbartel
force-pushed
the
f/alternate_data_formats/isolated
branch
from
4c3b081 to
07e3dc0
Compare
Contributor
Author
|
@aaraney, I've rebased and force-push the updated branch, so this will need another review. |
aaraney
approved these changes
Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for data formats to have satisfactory alternate formats. This enables, e.g., a requirement for a forcing dataset to be fulfilled by a dataset with a format that doesn't strictly match that specified by the requirement.
Note that this supersedes #276. It is effectively the same change set (small modifications were done due to package versions needing to be further bumped) rebased onto the current
mastercommit.